Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fix for debuginfo that can be None #1469

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Small fix for debuginfo that can be None #1469

merged 4 commits into from
Dec 11, 2023

Conversation

kotsaloscv
Copy link
Collaborator

No description provided.

@kotsaloscv kotsaloscv self-assigned this Dec 4, 2023
BenWeber42
BenWeber42 reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@BenWeber42 BenWeber42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Not sure if this works out if filename is None 🤔

dace/sourcemap.py Outdated Show resolved Hide resolved
@kotsaloscv kotsaloscv mentioned this pull request Dec 5, 2023
Merged
BenWeber42
BenWeber42 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@BenWeber42 BenWeber42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the fix!

@BenWeber42 BenWeber42 enabled auto-merge (squash) December 11, 2023 12:13
@BenWeber42 BenWeber42 merged commit cfafe0f into master Dec 11, 2023
9 checks passed
@BenWeber42 BenWeber42 deleted the debinfo_fix branch December 11, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWeber42 BenWeber42 BenWeber42 approved these changes

Assignees

@kotsaloscv kotsaloscv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kotsaloscv @BenWeber42